Reward tracking #1653
Merged
Reward tracking #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sn_client/src/api.rs
Outdated
| @@ -105,11 +105,23 @@ | |||
| let root_dir = std::env::temp_dir(); | |||
| trace!("Starting Kad swarm in client mode..{root_dir:?}."); | |||
|
|
|||
| // TODO: shall client bearing owner's discord user name, to be reflected in the cash_notes? | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
maqi
force-pushed
the
reward_tracking
branch
3 times, most recently
from
cd567d7 to
b917a15
Compare
b-zee
reviewed
May 1, 2024
b-zee
reviewed
May 1, 2024
b-zee
reviewed
May 1, 2024
b-zee
reviewed
May 2, 2024
Comment on lines
+25
to
+40
| #[derive(Clone, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)] | ||
| pub struct SpendDagAddress { | ||
| address: SpendAddress, | ||
| purpose: String, | ||
| } | ||
|
|
||
| impl std::fmt::Debug for SpendDagAddress { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> std::fmt::Result { | ||
| write!( | ||
| f, | ||
| "address: {}\npurpose: {}", | ||
| &self.address.to_hex()[0..6], | ||
| self.purpose | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| #[derive(Clone, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)] | |
| pub struct SpendDagAddress { | |
| address: SpendAddress, | |
| purpose: String, | |
| } | |
| impl std::fmt::Debug for SpendDagAddress { | |
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> std::fmt::Result { | |
| write!( | |
| f, | |
| "address: {}\npurpose: {}", | |
| &self.address.to_hex()[0..6], | |
| self.purpose | |
| ) | |
| } | |
| } | |
| #[derive(Debug, Clone, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)] | |
| pub struct SpendDagAddress { | |
| address: SpendAddress, | |
| purpose: String, | |
| } |
There was a problem hiding this comment.
the default Debug doesn't have the line break, which gives a better output in the diagraph.
hence it has to be individually implemented.
b-zee
approved these changes
May 2, 2024
RolandSherwin
approved these changes
May 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviewpad:summary