fix(node): avoid false alert on FailedLocalRecord #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| send_swarm_cmd(self.swarm_cmd_sender.clone(), cmd); | ||
| return Err(error); | ||
| } | ||
| self.prune_records_if_needed(&r.key)?; |
There was a problem hiding this comment.
'r' should not be a variable name. We need descriptive variable names.
I will approve but please use a descriptive name.
JasonPaulGithub
approved these changes
Apr 17, 2024
JasonPaulGithub
added
Small
JasonPaulGithub
force-pushed
the
avoid_false_alert_on_FailedLocalRecord
branch
from
1670edd to
0d2deed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviewpad:summary