Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Rpc restart #1608

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Feat: Rpc restart #1608

merged 2 commits into from
Apr 17, 2024

Conversation

JasonPaulGithub
Copy link
Contributor

@JasonPaulGithub JasonPaulGithub commented Apr 11, 2024 •
edited
Loading

Add a restart command to the cli commands for the node manager allowing it to restart nodes.

cargo run --bin safenode-manager --features local-discovery -- rpc restart --socket-address 127.0.0.1:59088

  • Manual testing (local network).

@JasonPaulGithub JasonPaulGithub added the Enhancement New feature or request label Apr 11, 2024
@JasonPaulGithub JasonPaulGithub marked this pull request as ready for review April 15, 2024 10:15
@JasonPaulGithub JasonPaulGithub self-assigned this Apr 15, 2024
@JasonPaulGithub JasonPaulGithub added the Small Pull request is small label Apr 15, 2024
jacderida
jacderida requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@jacderida jacderida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please squash the two commits into one?

sn_node_manager/src/rpc_client.rs Outdated Show resolved Hide resolved
sn_node_manager/src/bin/cli/main.rs Outdated Show resolved Hide resolved
sn_node_manager/src/bin/cli/main.rs Outdated Show resolved Hide resolved
sn_node_manager/src/bin/cli/main.rs Outdated Show resolved Hide resolved
sn_node_manager/src/bin/cli/main.rs Outdated Show resolved Hide resolved
sn_node_manager/src/rpc_client.rs Outdated Show resolved Hide resolved
sn_node_manager/src/rpc_client.rs Outdated Show resolved Hide resolved
sn_node_manager/src/rpc_client.rs Outdated Show resolved Hide resolved
sn_node_manager/src/rpc_client.rs Outdated Show resolved Hide resolved
sn_node_manager/src/rpc_client.rs Outdated Show resolved Hide resolved
@jacderida jacderida enabled auto-merge April 16, 2024 20:39
@jacderida jacderida added this pull request to the merge queue Apr 17, 2024
Merged via the queue into maidsafe:main with commit 6da215f Apr 17, 2024
50 checks passed
@JasonPaulGithub JasonPaulGithub deleted the rpc_restart branch April 18, 2024 12:57
@JasonPaulGithub JasonPaulGithub restored the rpc_restart branch April 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacderida jacderida jacderida approved these changes

Assignees

@JasonPaulGithub JasonPaulGithub

Labels
Enhancement New feature or request Small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonPaulGithub @jacderida