Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report protocol mismatch error #1577

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

RolandSherwin
Copy link
Member

This would allow the clients to timeout with the proper error message.

Comment on lines -223 to -225
let peer_is_agent = info
.agent_version
.starts_with(&IDENTIFY_NODE_VERSION_STR.to_string());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should match the whole string here. And we are checking the peer is a node, so renamed the variable.

@JasonPaulGithub JasonPaulGithub added Enhancement New feature or request Small Pull request is small labels Apr 6, 2024
@JasonPaulGithub JasonPaulGithub added the Merge When Ready PR is in "Merge When Ready" label Apr 6, 2024
@RolandSherwin RolandSherwin added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@RolandSherwin RolandSherwin added this pull request to the merge queue Apr 8, 2024
Merged via the queue into maidsafe:main with commit f50a71f Apr 8, 2024
53 checks passed
@RolandSherwin RolandSherwin deleted the network_version branch April 8, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Merge When Ready PR is in "Merge When Ready" Small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants