testnet sandboxing and alpha tweaks. #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
force-pushed
the
alpha-tweaksformain
branch
from
17d3c8b to
6abd92f
Compare
This change exists just to generate a new version number. We can remove it if necessary.
There was an issue with the script always applying 0 for the pre-release identifier. We got into a situation where it actually needed to be incremented by 1, because there was already a crate published at the 0 version. Added some text output to help clarify what the script is doing. Also tidied the style by consistently applying Bash syntax (as opposed to POSIX compatible) and a tab size of 2.
Just removed a few words to try and effect another change in `sn_client`, to get a new version. This crate has already been published and references an older version of `sn_protocol`, which is causing a problem because `sn_cli` is referencing a newer version of it.
Again, these changes are just to effect a release. A change to the release workflow also removes testing the environment variable and re-exporting it. On the last build I ran, it appears to have worked as expected, where previously it didn't. Doesn't really make any sense.
joshuef
force-pushed
the
alpha-tweaksformain
branch
from
6abd92f to
868a0a1
Compare
RolandSherwin
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviewpad:summary