LUA: reduce file IO cpu overhead and properly close the file

magicrub · Feb 6, 2024 · 2540e67 · 2540e67
1 parent 4d540d7
commit 2540e67
Showing 1 changed file with 15 additions and 12 deletions.
diff --git a/ROMFS/scripts/maim_web.lua b/ROMFS/scripts/maim_web.lua
@@ -118,22 +118,25 @@ local function update() -- this is the loop which periodically runs
                 path = request_uri
             end
 
-            -- send response
-            local file = io.open("./scripts" .. path, "r")
-            if not file then
-                file = io.open("@ROMFS/scripts" .. path, "r")
-            end
-            if not file then
-                file = io.open("ROMFS/scripts" .. path, "r")
-            end
+            if string.find(path, ".html") ~= nil then
+                -- send html file if exists in one of these directories
+                local file = io.open("@ROMFS/scripts" .. path, "r") -- scenario for STM32 /ROMFS/scripts
+                if not file then
+                    file = io.open("ROMFS/scripts" .. path, "r") -- scenario for SITL /ROMFS/scripts
+                end
+                if not file then
+                    file = io.open("./scripts" .. path, "r")
+                end
 
-            -- send html file if exists
-            if file then
-                if path:match(".html") then
+                if file then
                     send_str("HTTP/1.1 200 OK\r\nContent-Type: text/html\r\nConnection: close\r\n\r\n")
                     send_str(file:read("*a"))
+                    file:close()
+                else
+                    -- send 404 if file not found
+                    send_str("HTTP/1.1 404 Not Found\r\nContent-Type: text/html\r\nConnection: close\r\n\r\n")
+                    send_str("<html><body><h1>404 Not Found</h1></body></html>")
                 end
-                file:close()
 
             elseif path == "/zeroize" then
                 mod_payload:set_zeroize()