-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Variable components number #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notdanilo
force-pushed
the
feature/variable-components-number
branch
2 times, most recently
from
January 16, 2025 13:02
f11d548
to
ebf4295
Compare
notdanilo
changed the title
Feature/variable components number
✨ Variable components number
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22 file(s) reviewed, 19 comment(s)
Edit PR Review Bot Settings | Greptile
notdanilo
force-pushed
the
feature/variable-components-number
branch
from
January 16, 2025 21:13
ebf4295
to
3dba024
Compare
notdanilo
force-pushed
the
feature/variable-components-number
branch
from
January 16, 2025 21:42
3dba024
to
972a8d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What problem are you trying to solve?
Max components is currently limited to 5.
Solution
Use the remaining accounts to flexibilize the number of components. It will get rid of the #[system_template(max_components = X)] macro which creates a burden for maintainability.
Greptile Summary
This PR removes the fixed maximum component limit (previously 5) in favor of a more flexible approach using remaining accounts for the Bolt framework.
bolt-helpers
crate and associated macros (#[system_template(max_components = X)]
) to improve maintainabilityapply
functions into a single flexible implementation using remaining accountsbolt-lang
attributes to support variable component numbers throughNumberOfComponents
traitInvalidSystemOutput
error handling for the variable components approach💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!