✨ Adding low and intermediate api-levels #120
Conversation
notdanilo
force-pushed
the
feature/api-levels
branch
2 times, most recently
from
398c4a4 to
37d38c3
Compare
notdanilo
force-pushed
the
feature/api-levels
branch
from
37d38c3 to
390b1fb
Compare
notdanilo
force-pushed
the
feature/api-levels
branch
from
69671c0 to
548f592
Compare
notdanilo
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| ); | ||
| }); | ||
|
|
||
| it("Initialize Original Component on Entity 2, trough the world instance", async () => { |
There was a problem hiding this comment.
syntax: 'trough' is misspelled in the test name, should be 'through'
| const signature = await provider.sendAndConfirm(transaction, [], { | ||
| skipPreflight: true, | ||
| }); | ||
| console.log(`Whitelist 2 system approval signature: ${signature}`); |
There was a problem hiding this comment.
logic: Log message refers to 'Whitelist 2' but this is the first whitelist operation
There was a problem hiding this comment.
11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| } | ||
|
|
||
| // TODO: seed must be Uint8Array like the other FindPda functions |
There was a problem hiding this comment.
logic: this TODO should be addressed before merging - inconsistent seed types between functions could lead to runtime errors
| ); | ||
| }); | ||
|
|
||
| it("InitializeNewWorld 2", async () => { |
There was a problem hiding this comment.
logic: The worldId and worldPda variables from the first world initialization are shadowed here, which could lead to state inconsistencies in subsequent tests
Problem & Solution
Are both described in the issue #119
This PR also
Includes: #58
Greptile Summary
This PR introduces API level abstractions (low/intermediate/high) to the Bolt framework and optimizes entity PDA generation for improved performance.
clients/bolt-sdk/src/index.tsto useworld.keyinstead ofworld.idto avoid unnecessary RPC callstests/bolt.low-level.api.tsfor direct Anchor interactionstests/bolt.intermediate-level.api.tswith higher abstractionsclients/bolt-sdk/src/generated/types/world.tsAnchor.tomltest scripts to run both API level tests with proper timing💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!