Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added guitar features and minor fixes #9

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

4ntsu
Copy link

@4ntsu 4ntsu commented May 16, 2023

Hi,

This PR adds some new guitar functionality and addresses a few issues:

  • Adds support for the touch-sensitive neck slider on Guitar Hero World Tour guitars and later, with precautions to not alter the behaviour on older models that don't have this feature.
  • Adds the analog stick's values to the map of guitar values.
  • Changes the behaviour of the plus and minus buttons on guitars, from an axis to individual buttons.
  • Addresses bug typo in Readme #1 (and my accidental duplicate Values array index off by one in the README file #7) by syncing the value mappings for all peripherals to their respective code.

I have not touched on the analog ranges for other peripherals (as mentioned in #8), as I haven't had confirmation whether or not this is intentional and I don't have these devices for testing, but for the guitar the ranges are now correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant