Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented filters of Dataframe. #485

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

KFilippopolitis
Copy link
Contributor

@KFilippopolitis KFilippopolitis commented Jun 14, 2024

No description provided.

@KFilippopolitis KFilippopolitis force-pushed the implement_filters_on_flower branch from a43b821 to b9a1e88 Compare June 14, 2024 12:23
@KFilippopolitis KFilippopolitis changed the title New mipdb version. Implemented filters of Dataframe. Jun 14, 2024
@KFilippopolitis KFilippopolitis changed the base branch from master to client_load_data_from_csv June 14, 2024 12:26
@KFilippopolitis KFilippopolitis force-pushed the implement_filters_on_flower branch from b9a1e88 to e9b3cfe Compare June 14, 2024 14:36
@KFilippopolitis KFilippopolitis changed the base branch from client_load_data_from_csv to master June 14, 2024 14:41
@KFilippopolitis KFilippopolitis force-pushed the implement_filters_on_flower branch 3 times, most recently from bf116b1 to 78b1a0c Compare June 14, 2024 16:10
@KFilippopolitis KFilippopolitis force-pushed the implement_filters_on_flower branch from 78b1a0c to 14dd394 Compare July 3, 2024 09:02
@KFilippopolitis KFilippopolitis changed the base branch from master to client_load_data_from_csv July 3, 2024 09:02
Copy link
Member

@ThanKarab ThanKarab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀

@@ -0,0 +1,353 @@
import pandas as pd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it will be very difficult to maintain and distinguish the test cases in the future you can use something similar to this:

It is actually naming each test case input so you know what you are testing.

Please try to add an explanatory name so that we can maintain it in the future.

@KFilippopolitis KFilippopolitis force-pushed the client_load_data_from_csv branch from b257637 to 2db7dcf Compare July 9, 2024 20:38
Base automatically changed from client_load_data_from_csv to master July 9, 2024 20:59
@KFilippopolitis KFilippopolitis force-pushed the implement_filters_on_flower branch from 14dd394 to 4aa7a22 Compare July 9, 2024 21:14
@KFilippopolitis KFilippopolitis merged commit f673763 into master Jul 9, 2024
5 of 7 checks passed
@KFilippopolitis KFilippopolitis deleted the implement_filters_on_flower branch July 9, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants