Anova Oneway implementation #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jassak
commented
Jan 17, 2021
•
jassak
commented
- Implementation of Oneway Anova algorithm for one categorical and one numerical variable
- Output of Anova includes:
- Anova summary table
- Tukey Honest Significant Differences test table
- Mean plot for every level in the categorical variable
- 95 Algorithm tests (80 local + 15 federated on 10 nodes)
- 5 Exareme integration tests
- 1 Privacy test
- No property based testing (yet)
Doesn't work correctly yet! Midway refactoring: removing the possibility to run anova on multiple covariables, as this would be best implemented using a) the formula and b) a linear regression model as a first step. Since we don't yet have formulae and algorithm pipelines there is no point in implementing the multivariate anova version.
Plus, add Tukey table to raw output.
Adds statmodels in Dockerfile also
ThanKarab
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.