Memory Leak Fix: Implementing jemalloc Allocator (#205)

* update: added jemallocator
madara-alliance · Jan 24, 2025 · afb9afe · afb9afe
1 parent 9000464
commit afb9afe
Show file tree

Hide file tree

Showing 7 changed files with 33 additions and 0 deletions.
diff --git a/.env.example b/.env.example
@@ -1,3 +1,6 @@
+#### SYSTEM ####
+JEMALLOC_SYS_WITH_MALLOC_CONF=
+
 #### AWS CONFIG ####
 AWS_ACCESS_KEY_ID=                    # Your AWS access key ID
 AWS_SECRET_ACCESS_KEY=                # Your AWS secret access key

diff --git a/.env.test b/.env.test
@@ -1,3 +1,5 @@
+#### SYSTEM ####
+JEMALLOC_SYS_WITH_MALLOC_CONF="background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,abort_conf:true"
 
 #### AWS CONFIG ####
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -86,6 +86,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ## Fixed
 
+- add jemallocator to fix memory leak
 - refactor: instrumentation
 - `is_worker_enabled` status check moved from `VerificationFailed` to `Failed`
 - refactor: static attributes for telemetry

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -130,6 +130,7 @@ cairo-vm = { git = "https://github.com/Moonsong-Labs/cairo-vm", branch = "notles
   "mod_builtin",
 ] }
 
+jemallocator = "0.5.4"
 
 # Snos & Sharp (Starkware)
 # TODO: need to update this once the updated PR merges

diff --git a/crates/orchestrator/Cargo.toml b/crates/orchestrator/Cargo.toml
@@ -93,6 +93,8 @@ tracing-core = { workspace = true, default-features = false }
 tracing-opentelemetry = { workspace = true }
 tracing-subscriber = { workspace = true, features = ["env-filter"] }
 
+jemallocator = { workspace = true }
+
 [features]
 default = ["ethereum", "with_mongodb", "with_sqs"]
 ethereum = ["ethereum-da-client"]

diff --git a/crates/orchestrator/src/main.rs b/crates/orchestrator/src/main.rs
@@ -7,6 +7,9 @@ use orchestrator::routes::setup_server;
 use orchestrator::setup::setup_cloud;
 use orchestrator::telemetry::{setup_analytics, shutdown_analytics};
 
+#[global_allocator]
+static A: jemallocator::Jemalloc = jemallocator::Jemalloc;
+
 /// Start the server
 #[tokio::main]
 // not sure why clippy gives this error on the latest rust