Feat : Safe Proxy changes and Wallet init changes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+146
to
+147
| calldata.extend(empty_bytes); | ||
| calldata.extend(empty_bytes); |
There was a problem hiding this comment.
let's add comments on what these empty bytes represent
Comment on lines
+169
to
+170
| calldata.extend(empty_bytes); | ||
| calldata.extend(empty_bytes); |
| program_hash: convert_felt_to_u256(program_hash), // zero program hash would be deemed invalid | ||
| verifier_address: Address::zero(), |
There was a problem hiding this comment.
yeh bhi argument mein le lete hai
Comment on lines
110
to
122
| let program_hash = StarkFelt(program_hash.to_bytes_be()); | ||
|
|
||
| let init_data = Self::get_init_data_core_contract(block_number, state_root, program_hash, config_hash); | ||
|
|
||
| let mut zero_address_bytes = Address::zero().encode(); | ||
| let bytes: Vec<u8> = <CoreContractInitData as Into<Vec<u8>>>::into(init_data.clone()); | ||
| for x in bytes { | ||
| zero_address_bytes.push(x); | ||
| } | ||
|
|
||
| let final_bytes = zero_address_bytes; | ||
|
|
||
| log::debug!("ℹ️ upgrade_to : data : {:?} : {:?}", init_data, Bytes::from(final_bytes.clone())); |
There was a problem hiding this comment.
this looks same as above, should we move it to a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.