Make GUI tabs track Vim tabs in updates and animate correctly #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
added
the
UI
|
Just to demonstrate what this PR will do and how the tabs will animate to the correct locations no matter what Vim commands we use:
tabnew-tabclose.mov
bdelete.mov
tabmove.movExisting functionality from MMTab where we defer resizing the tab while closing tabs using the UI. This still works after this change: defer-resize.movEven dragging a tab while another tab is closed also works seamlessly: drag-while-tabclose.mov |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (9)
- src/MacVim/MMBackend.m: Language not supported
- src/MacVim/MMTabline/MMTab.h: Language not supported
- src/MacVim/MMTabline/MMTab.m: Language not supported
- src/MacVim/MMTabline/MMTabline.h: Language not supported
- src/MacVim/MMTabline/MMTabline.m: Language not supported
- src/MacVim/MMVimView.h: Language not supported
- src/MacVim/MMVimView.m: Language not supported
- src/MacVim/MMWindowController.h: Language not supported
- src/MacVim/MMWindowController.m: Language not supported
ychin
force-pushed
the
mmtabs-fix-update-animation-scroll
branch
from
f8bf3fd to
b589c84
Compare
MMTabline was introduced in macvim-dev#1120, which replaced the ancient PSMTabBarControl for representing Vim tabs. It uses animation to handle tab layouts, but it only worked in some situations, due to the Vim IPC API only sending a tabline update with all the tab labels with no way to track individual tabs. Update the API so that Vim now sends individual unique IDs in the update message as well to allow the GUI to track tabs over time and animate them. Vim does not interally have a concept of unique tab IDs, but we can use the pointer to the structure as such because they are allocated as a linked list and will never change. Extend MMTabline to have a new `updateTabsByTags` API to batch update all tabs in one go, which will diff the new tags with existing tabs and create/remove/move tabs as necessary. The scrolling logic has also been moved inside it and it now only scrolls to selected tab when it has changed or moved. When deleting tabs we won't scroll as usually the user doesn't expect it. Dragging tabs also now work correctly when it is removed during a drag, or another tab has been selected. This does mean the add/close tab APIs are currently unused, as the only entrypoint for modifying tabs from MacVim is currently only via `updateTabsByTags`. After this, different Vim operations will now animate correctly, including `:tabmove`, `:bdelete` (which could remove multiple tabs at once), `:tabnew`, `:tabclose`.
ychin
force-pushed
the
mmtabs-fix-update-animation-scroll
branch
from
b589c84 to
7fbb445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MMTabline was introduced in #1120, which replaced the ancient PSMTabBarControl for representing Vim tabs. It uses animation to handle tab layouts, but it only worked in some situations, due to the Vim IPC API only sending a tabline update with all the tab labels with no way to track individual tabs. Update the API so that Vim now sends individual unique IDs in the update message as well to allow the GUI to track tabs over time and animate them. Vim does not interally have a concept of unique tab IDs, but we can use the pointer to the structure as such because they are allocated as a linked list and will never change.
Extend MMTabline to have a new
updateTabsByTagsAPI to batch update all tabs in one go, which will diff the new tags with existing tabs and create/remove/move tabs as necessary. The scrolling logic has also been moved inside it and it now only scrolls to selected tab when it has changed or moved. When deleting tabs we won't scroll as usually the user doesn't expect it. Dragging tabs also now work correctly when it is removed during a drag, or another tab has been selected.This does mean the add/close tab APIs are currently unused, as the only entrypoint for modifying tabs from MacVim is currently only via
updateTabsByTags.After this, different Vim operations will now animate correctly, including
:tabmove,:bdelete(which could remove multiple tabs at once),:tabnew,:tabclose.