Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portindex: spoof compiler version #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohd-akram
Copy link
Member

@mohd-akram mohd-akram commented Jan 5, 2025

@mohd-akram mohd-akram force-pushed the portindex-spoof-compiler branch from ec29f4b to 4134d68 Compare January 5, 2025 13:44
@mohd-akram mohd-akram requested a review from jmroot January 5, 2025 13:44
@mohd-akram mohd-akram force-pushed the portindex-spoof-compiler branch from 4134d68 to 253ef34 Compare January 5, 2025 15:00
Copy link
Member

@jmroot jmroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to do this all the time, but only in pretend mode. This is also only one factor that can affect the output. If we're going to go down this path, I'd like to see a general mechanism for overriding variables, with the policy of what to set them to left to the caller.

@mohd-akram
Copy link
Member Author

We don't want to do this all the time, but only in pretend mode.

Currently the code is checking port_options to only do this in pretend mode.

This is also only one factor that can affect the output.

What are some others?

If we're going to go down this path, I'd like to see a general mechanism for overriding variables, with the policy of what to set them to left to the caller.

Within the scope of this PR or in the future? Do you mean the caller should specify the compiler version? I refrained from that because the caller would have to have knowledge of which Xcode version is supported on which macOS version, and which compiler comes with that Xcode. portindex is also called from a shell script, so the user has no easy access to the MacPorts API to aid with information like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants