getindex with ranges copy, as default in Julia

m3g · Sep 12, 2023 · 03934e0 · 03934e0
1 parent 75c363d
commit 03934e0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/datastructures/Positions.jl b/src/datastructures/Positions.jl
@@ -64,7 +64,7 @@ struct FramePositions{T<:AbstractArray}
 end
 FramePositions(f::Chemfiles.Frame) = FramePositions(Chemfiles.positions(f))
 Base.getindex(x::FramePositions, i::Int) = Point3D(@view(x.positions[:,i]))
-Base.getindex(x::FramePositions, r::AbstractUnitRange) = FramePositions(@view(x.positions[:,r]))
+Base.getindex(x::FramePositions, r::AbstractUnitRange) = FramePositions(x.positions[:,r])
 
 """
     positions(frame::Chemfiles.Frame)
@@ -119,4 +119,5 @@ view(positions::FramePositions, r::AbstractUnitRange) = FramePositions(@view(pos
     # test with range
     @test p[2:3] == FramePositions(m[:,2:3])
     @test p[2:3] ≈ FramePositions(m[:,2:3])
+    @test @view(p[2:3]) == FramePositions(m[:,2:3])
 end