Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat codebase with Ruff autoformatter and remove .ipynb checkpoints and *.pyc files #7

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Reformat codebase with Ruff autoformatter and remove .ipynb checkpoints and *.pyc files #7

merged 8 commits into from
Nov 14, 2024

Conversation

ma595
Copy link
Member

@ma595 ma595 commented Sep 11, 2024 •
edited
Loading

This PR renames the densite.py file to density.py, corrects a few spelling mistakes and applies Ruff autoformatter project-wide.

  • Add pre-commit locally
  • Add remote pre-commit check that ensures formatting (eol, ruff etc) pass.
  • Apply ruff project wide
  • Add remote ruff check
  • Remove .pyc and ipynb checkpoint files.

Closes #5

@ma595 ma595 self-assigned this Sep 11, 2024
@ma595 ma595 marked this pull request as draft September 11, 2024 20:58
@ma595 ma595 changed the title Reformat codebase with Ruff autoformatter [WIP] Reformat codebase with Ruff autoformatter Sep 11, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ma595 ma595 marked this pull request as ready for review September 18, 2024 20:28
@ma595 ma595 changed the title [WIP] Reformat codebase with Ruff autoformatter Reformat codebase with Ruff autoformatter Sep 18, 2024
surbhigoel77
surbhigoel77 reviewed Sep 23, 2024
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
surbhigoel77
surbhigoel77 previously approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@surbhigoel77 surbhigoel77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a comment on using pre-commit. Otherwise LGTM.

@ma595 ma595 requested a review from surbhigoel77 September 23, 2024 15:25
@ma595
Copy link
Member Author

ma595 commented Nov 7, 2024

@isaacaka can you please review this so we can get this merged.

isaacaka
isaacaka previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@isaacaka isaacaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@ma595 ma595 dismissed stale reviews from isaacaka and surbhigoel77 November 9, 2024 11:24

Needs re-reviewing

@ma595 ma595 requested a review from isaacaka November 11, 2024 16:53
@ma595
Copy link
Member Author

ma595 commented Nov 11, 2024 •
edited
Loading

I suspect there might be annoying issues with subsequent Jupyter files when attempting to rebase any subsequent branches off of these changes. @isaacaka do you think these would be too awful to fix?

@ma595 ma595 mentioned this pull request Nov 11, 2024
Merged
@ma595 ma595 added the iccs label Nov 11, 2024
@ma595 ma595 changed the title Reformat codebase with Ruff autoformatter Reformat codebase with Ruff autoformatter and remove .ipynb checkpoints and *.pyc files Nov 12, 2024
surbhigoel77
surbhigoel77 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@surbhigoel77 surbhigoel77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left a couple of minor comments. Otherwise LGTM.

surbhigoel77
surbhigoel77 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@surbhigoel77 surbhigoel77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ma595 ma595 merged commit 9c17972 into main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigoel77 surbhigoel77 surbhigoel77 approved these changes

@isaacaka isaacaka Awaiting requested review from isaacaka

Assignees

@ma595 ma595

Labels
iccs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code style
3 participants
@ma595 @surbhigoel77 @isaacaka