-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not fail on empty # and #top fragments #1609
Conversation
21b9188
to
bd21857
Compare
Went with the two
On my local tests, randomly, at least one, up to all of those failed. Would be interesting to know where this inconsistency is coming from, as I would suggest the same fragment to succeed or fail every time the same way 🤔. |
updated my findings, the resolution and test information in here please let me know if this works. |
2a46b4d
to
4158f2a
Compare
Awesome, the embarrassingly missed empty/top fragment handling in case of existing cache entry was the solution 👍. The redundant |
3cac5a2
to
17bf32c
Compare
@MichaIng, sorry, I dropped the ball on that one. What's the current status on this? |
@mre .map_or(false, ... to .is_some_and(... seems sane. But in a dedicated PR I suggest. |
The empty "#" and "#top" fragments are always valid without related HTML element. Browser will scroll to the top of the page. Hence lychee must not fail on those. Credits go to @thiru-appitap for initial attempt and helping to find missing parts of the implementation. Solves: lycheeverse#1599 Signed-off-by: MichaIng <[email protected]>
17bf32c
to
7b15a2c
Compare
Thanks to you both, @thiru-appitap and @MichaIng. 🎉 |
The empty "#" and "#top" fragments are always valid without related HTML element. Browser will scroll to the top of the page. Hence lychee must not fail on those.
Fixed #1599