Add integration test

lycheeverse · Nov 29, 2024 · 2489d56 · 2489d56
1 parent 4de28cd
commit 2489d56
Show file tree

Hide file tree

Showing 5 changed files with 61 additions and 5 deletions.
diff --git a/fixtures/resolve_paths_from_root_path/nested/about/index.html b/fixtures/resolve_paths_from_root_path/nested/about/index.html
@@ -0,0 +1,8 @@
+<html>
+  <head>
+    <title>About</title>
+  </head>
+  <body>
+    <h1 id="fragment">About</h1>
+  </body>
+</html>
diff --git a/fixtures/resolve_paths_from_root_path/nested/another page/index.html b/fixtures/resolve_paths_from_root_path/nested/another page/index.html
diff --git a/fixtures/resolve_paths_from_root_path/nested/index.html b/fixtures/resolve_paths_from_root_path/nested/index.html
@@ -0,0 +1,34 @@
+<html>
+    <head>
+        <title>Index</title>
+    </head>
+    <body>
+        <h1>Index Title</h1>
+        <a id="good"></a>
+        <p>
+            <ul>
+                <li>
+                    <a href="/nested">home</a>
+                </li>
+                <li>
+                    <a href="/nested/about">About</a>
+                </li>
+                <li>
+                    <a href="/nested/another page">About</a>
+                </li>
+                <li>
+                    <a href="/nested/about/index.html#fragment">Fragment</a>
+                </li>
+                <li>
+                    <a href="/nested/about/index.html#missing">Missing</a>
+                </li>
+                <li>
+                    <a href="#good">Good</a>
+                </li>
+                <li>
+                    <a href="#bad">Bad</a>
+                </li>
+            </ul>
+        </p>
+    </body>
+</html>
diff --git a/lychee-bin/tests/cli.rs b/lychee-bin/tests/cli.rs
@@ -393,6 +393,24 @@ mod cli {
             .stdout(contains("3 OK"));
     }
 
+    #[test]
+    fn test_resolve_paths_from_root_path() {
+        let mut cmd = main_command();
+        let dir = fixtures_path().join("resolve_paths_from_root_path");
+
+        cmd.arg("--offline")
+            .arg("--include-fragments")
+            .arg("--root-path")
+            .arg(&dir)
+            .arg(dir.join("nested").join("index.html"))
+            .env_clear()
+            .assert()
+            .failure()
+            .stdout(contains("7 Total"))
+            .stdout(contains("5 OK"))
+            .stdout(contains("2 Errors"));
+    }
+
     #[test]
     fn test_youtube_quirk() {
         let url = "https://www.youtube.com/watch?v=NlKuICiT470&list=PLbWDhxwM_45mPVToqaIZNbZeIzFchsKKQ&index=7";

diff --git a/lychee-lib/src/types/input.rs b/lychee-lib/src/types/input.rs
@@ -140,11 +140,7 @@ impl Input {
                 Ok(url) if url.scheme() == "http" || url.scheme() == "https" => {
                     InputSource::RemoteUrl(Box::new(url))
                 }
-                Ok(_) => {
-                    // URL parsed successfully, but it's not http or https
-                    return Err(ErrorKind::InvalidFile(PathBuf::from(value)));
-                }
-                _ => {
+                Ok(_) | _ => {
                     // this seems to be the only way to determine if this is a glob pattern
                     let is_glob = glob::Pattern::escape(value) != value;