Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Edges and Edit Mode #373

Merged
merged 18 commits into from
Sep 8, 2021
Merged

Add Edges and Edit Mode #373

merged 18 commits into from
Sep 8, 2021

Conversation

runette
Copy link
Contributor

@runette runette commented Aug 21, 2021 •
edited
Loading

fixes #360

This should be the last of updates needed for the next Python version.

  • Adds the C and C++ methods to add edges to an editable mesh
  • Updates and extends the API tests to include the edge API

PeterPetrik
PeterPetrik reviewed Aug 31, 2021
View reviewed changes
Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will have more time later this week to review your work!

mdal/api/mdal.h Outdated Show resolved Hide resolved
mdal/api/mdal.h Show resolved Hide resolved
tests/test_api.cpp Show resolved Hide resolved
tests/test_api.cpp Show resolved Hide resolved
mdal/mdal_data_model.hpp Show resolved Hide resolved
@PeterPetrik PeterPetrik merged commit 7ccb896 into lutraconsulting:master Sep 8, 2021
@runette runette deleted the editmode branch September 8, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterPetrik PeterPetrik PeterPetrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The C API (and the C++ API) do not seem to have the calls to addEdges
2 participants
@runette @PeterPetrik