Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test Spartan2 optimizations #370

Closed
wants to merge 1 commit into from
Closed

Conversation

winston-h-zhang
Copy link
Contributor

Resolves #368

@winston-h-zhang
Copy link
Contributor Author

!benchmark

Copy link
Contributor

!benchmark action failed ❌

https://github.com/lurk-lab/arecibo/actions/runs/8333148781

@winston-h-zhang
Copy link
Contributor Author

!gpu-benchmark

Copy link
Contributor

!gpu-benchmark action failed ❌

https://github.com/lurk-lab/arecibo/actions/runs/8333236689

@winston-h-zhang
Copy link
Contributor Author

Ok, I just produced the benchmarks on my machine directly:

Benchmarks

Table of Contents

Benchmark Results

RecursiveSNARK

ref=b4bfe89 ref=ed56335
Prove-NumCons-0 56.56 ms (✅ 1.00x) 55.38 ms (✅ 1.02x faster)
Verify-NumCons-0 49.51 ms (✅ 1.00x) 49.68 ms (✅ 1.00x slower)
Prove-NumCons-6559 68.23 ms (✅ 1.00x) 70.60 ms (✅ 1.03x slower)
Verify-NumCons-6559 59.91 ms (✅ 1.00x) 60.90 ms (✅ 1.02x slower)
Prove-NumCons-22943 104.66 ms (✅ 1.00x) 102.11 ms (✅ 1.03x faster)
Verify-NumCons-22943 93.75 ms (✅ 1.00x) 92.37 ms (✅ 1.01x faster)
Prove-NumCons-55711 69.71 ms (✅ 1.00x) 70.75 ms (✅ 1.01x slower)
Verify-NumCons-55711 46.75 ms (✅ 1.00x) 42.70 ms (✅ 1.10x faster)
Prove-NumCons-121247 94.20 ms (✅ 1.00x) 95.17 ms (✅ 1.01x slower)
Verify-NumCons-121247 55.73 ms (✅ 1.00x) 50.19 ms (✅ 1.11x faster)
Prove-NumCons-252319 159.00 ms (✅ 1.00x) 159.15 ms (✅ 1.00x slower)
Verify-NumCons-252319 75.13 ms (✅ 1.00x) 69.85 ms (✅ 1.08x faster)
Prove-NumCons-514463 220.69 ms (✅ 1.00x) 225.63 ms (✅ 1.02x slower)
Verify-NumCons-514463 90.14 ms (✅ 1.00x) 84.63 ms (✅ 1.07x faster)
Prove-NumCons-1038751 364.35 ms (✅ 1.00x) 372.00 ms (✅ 1.02x slower)
Verify-NumCons-1038751 130.28 ms (✅ 1.00x) 144.13 ms (✅ 1.11x slower)

Made with criterion-table

@huitseeker
Copy link
Contributor

Closing, see reasoning in #368 (comment)
Thanks for working that out @winston-h-zhang, much appreciated.

@huitseeker huitseeker closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpMVM acceleration on the CPU
2 participants