Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor dependencies in Cargo.toml to no longer fork pasta #333

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

huitseeker
Copy link
Contributor

@huitseeker huitseeker commented Feb 19, 2024

After:

Details:

  • Updated dependencies in Cargo.toml by switching pasta_curves from a git repository to a specific version
  • Amended grumpkin-msm dependency git repository link
  • Removed the [patch.crates-io] section for pasta_curves due to the above changes.

Note

CI complaining on repo provenance 100% expected until above dependencies merge.

Fixes #332

- Updated dependencies in Cargo.toml by switching `pasta_curves` from a git repository to a specific version
- Amended `grumpkin-msm` dependency git repository link
- Removed the `[patch.crates-io]` section for `pasta_curves` due to the above changes.
@huitseeker huitseeker force-pushed the move_out_from_pasta_fork branch from 67a045e to 1947b55 Compare February 20, 2024 00:58
@huitseeker huitseeker enabled auto-merge February 20, 2024 01:30
@huitseeker huitseeker added this pull request to the merge queue Feb 20, 2024
Merged via the queue into lurk-lang:dev with commit 9cdccb3 Feb 20, 2024
9 checks passed
@huitseeker huitseeker deleted the move_out_from_pasta_fork branch February 20, 2024 01:53
huitseeker added a commit to huitseeker/lurk-rs that referenced this pull request Feb 20, 2024
- Updated `pasta_curves` package to version "0.5.0" in Cargo.toml.
- Removed `pasta_curves` patch from `crates-io` due to redundancy with `bn256_grumpkin` traits.

This is obsolete since lurk-lang/arecibo#333
github-merge-queue bot pushed a commit to lurk-lab/lurk-beta that referenced this pull request Feb 20, 2024
- Updated `pasta_curves` package to version "0.5.0" in Cargo.toml.
- Removed `pasta_curves` patch from `crates-io` due to redundancy with `bn256_grumpkin` traits.

This is obsolete since lurk-lang/arecibo#333
winston-h-zhang pushed a commit to lurk-lab/lurk-beta that referenced this pull request Feb 27, 2024
- Updated `pasta_curves` package to version "0.5.0" in Cargo.toml.
- Removed `pasta_curves` patch from `crates-io` due to redundancy with `bn256_grumpkin` traits.

This is obsolete since lurk-lang/arecibo#333
github-actions bot pushed a commit that referenced this pull request Dec 16, 2024
* Squashed commit of the following:

commit cd8559dd3b08261121e4ac797bd364de317c9467
Author: Forpee <[email protected]>
Date:   Wed Nov 6 12:38:02 2024 +0200

    chore: restore cargo

commit f190e75d215b8a73d66c559d427b5e536ddb9c4e
Author: Forpee <[email protected]>
Date:   Wed Nov 6 12:32:32 2024 +0200

    chore: fix warnings, docs, clippy, fmt

commit b849a82e2d142c0fd1564721785295c67c4f2d34
Author: Forpee <[email protected]>
Date:   Wed Nov 6 11:56:28 2024 +0200

    chore: do some doc comments

commit 1fb584f14216f187a42b0eae9e5550042c08e31c
Author: Forpee <[email protected]>
Date:   Wed Nov 6 11:39:23 2024 +0200

    chore: clean up warnings

commit c68b709c53e812bac02bf09f43c08b0f8ce9f1bb
Author: Forpee <[email protected]>
Date:   Wed Nov 6 11:28:21 2024 +0200

    feat: add alloc_precommitted

commit 1642f15efb44c88a990f3e84e9c2a9d11b7bb735
Author: Forpee <[email protected]>
Date:   Wed Nov 6 11:18:36 2024 +0200

    feat: init precommitted var

commit 4aa27a7a32073bf6a3e87d5a9f9cafc2a305b853
Author: Forpee <[email protected]>
Date:   Wed Nov 6 10:53:59 2024 +0200

    chore: make poseidon folder

commit 110e782d888e56c9ea2fba75b807e201f97bc2c1
Author: Forpee <[email protected]>
Date:   Tue Nov 5 23:05:29 2024 +0200

    chore: rm doc tests

commit e9426b2d30078841c2b17492ce96e26e19d41d47
Author: Forpee <[email protected]>
Date:   Tue Nov 5 23:05:04 2024 +0200

    fix: poseidon in pp

commit aa12cbf04bdab6e5d18f45dceb0de6f33dd25dd5
Author: Forpee <[email protected]>
Date:   Tue Nov 5 22:04:57 2024 +0200

    feat: init new CS

commit 54cb3dfd0df2cc4bbde97b475daa4058680d14ff
Author: Forpee <[email protected]>
Date:   Tue Nov 5 20:38:43 2024 +0200

    feat: port poseidon sponge

commit e1368fdd74cd52cbcf65143e6e19d391a861ad66
Author: Forpee <[email protected]>
Date:   Tue Nov 5 20:34:12 2024 +0200

    feat: implement poseidon

commit 3d2e6fad71016afcec88f24c8219240e366f047e
Author: Forpee <[email protected]>
Date:   Tue Nov 5 18:41:20 2024 +0200

    feat: poseidon consts

commit f002464ab64933aa05667976ea9a2e3249ba552d
Author: Forpee <[email protected]>
Date:   Tue Nov 5 18:41:09 2024 +0200

    feat: init CS

commit 9ee87f60e2073ceb9031a93f1056ef10fb241ce2
Author: Forpee <[email protected]>
Date:   Tue Nov 5 14:40:46 2024 +0200

    fix: cargo

* chore: delete dead code, attribute original sources

* chore: rm precommitted var

* chore: rm unused var

* chore: cleanup deadcode and clippy warnings

* chore: cleanup up dead comment

* chore: clippy

* chore: cleanup deadcode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the pasta fork
2 participants