Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CycleFold #273

Merged
merged 77 commits into from
Mar 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
e63ea22
skeleton
mpenciak Jan 19, 2024
3f1c2bc
(wip) scalar <-> base confusion
mpenciak Jan 19, 2024
24eb599
(wip) fix W_new def
mpenciak Jan 22, 2024
9b0c6a9
(wip) fixed base <-> scalar confusion
mpenciak Jan 23, 2024
49fe8e4
(wip) new gadget scaffolding and allocated witnesses
mpenciak Jan 24, 2024
600e601
(wip) fix prove_step
mpenciak Jan 24, 2024
58c528f
(wip) synthesize_non_base_case
mpenciak Jan 25, 2024
3b373c8
(wip) synthesize
mpenciak Jan 25, 2024
5ec2882
(wip) synthesize_base_case
mpenciak Jan 25, 2024
e1adb35
(wip) fix absorbs
mpenciak Jan 25, 2024
fd5f5b9
(wip) stuck
mpenciak Jan 25, 2024
e324109
(wip) CommitmentKey macro
mpenciak Jan 29, 2024
9b68ff5
(wip) some gadgets filled
mpenciak Jan 31, 2024
dd60109
(wip) some more progress
mpenciak Feb 1, 2024
de9fbbe
(wip) Gadgets done, some cleanup
mpenciak Feb 4, 2024
bdcd68d
(wip) Scalar <-> Base confusion in verify
mpenciak Feb 5, 2024
ea69936
it builds!
mpenciak Feb 5, 2024
56e0b59
make clippy happy
mpenciak Feb 5, 2024
bf01a0b
Delete `RecursiveSNARKTrait` and cleanup
mpenciak Feb 5, 2024
787adda
refactor: Refactor data types and function signatures in Cyclefold mo…
huitseeker Feb 11, 2024
ecdc1c2
refactor: remove uneeded params in PublicParams, RecursiveSNARK
huitseeker Feb 11, 2024
b09059a
refactor: Remove option in CycleFoldInputs, remove a few needless typ…
huitseeker Feb 11, 2024
a169a23
test: use expect_test on brittle test
huitseeker Feb 11, 2024
40952a2
chore: update expect tests
huitseeker Feb 11, 2024
14dc4f1
(wip) addressing comments
mpenciak Feb 13, 2024
72a25cc
(wip) add recursive_snark test
mpenciak Feb 13, 2024
d7e30cf
(wip) add generic bounds for allocatedr1csinstances
mpenciak Feb 15, 2024
7f488bc
make the cyclefold test more **fun**
mpenciak Feb 15, 2024
ca4f46e
fix cyclefold circuit IO
mpenciak Feb 20, 2024
a3a722d
uncomment num_io cyclefold check
mpenciak Feb 20, 2024
6b46449
update constant
mpenciak Feb 20, 2024
eb92e4e
fix link
mpenciak Feb 20, 2024
87d1695
cleanup output
mpenciak Feb 20, 2024
7697e64
last couple circuit pieces
mpenciak Feb 20, 2024
6463bd9
add comm_T to inputs and add cyclefold IO checks
mpenciak Feb 20, 2024
7cb4a10
fix ro absorb numbers
mpenciak Feb 20, 2024
ee8cf69
remove extra unneeded comm_T allocation
mpenciak Feb 21, 2024
315d1ce
properly constrain `always_equal` in `mult_mod` and `red_mod`
mpenciak Feb 21, 2024
42830f5
some allocation fixes
mpenciak Feb 26, 2024
178bb1f
eliminate clone
mpenciak Feb 26, 2024
ceb9c6b
make RO absorb numbers make sense
mpenciak Feb 26, 2024
6a63178
fix cyclefold scalar alloc
mpenciak Feb 27, 2024
734dead
chore: update Bn256Engine -> Bn256EngineKZG
huitseeker Feb 27, 2024
fb85877
chore: run clippy
huitseeker Feb 27, 2024
ab73fa9
update `expect_test`s
mpenciak Feb 28, 2024
d1afdea
fix EmulatedCurveParam allocation
mpenciak Feb 28, 2024
e47d8ae
fix nifs RO absorb count
mpenciak Feb 28, 2024
3a3558c
make `test_augmented_circuit_size` an `expect_test`
mpenciak Feb 28, 2024
8d23795
fix: typo
mpenciak Feb 28, 2024
f630faf
fix: `RecursiveSNARK::new` sets i to 0
mpenciak Feb 28, 2024
695ff0c
fix: Fix RO absorb count in verify
mpenciak Feb 28, 2024
bd3076d
fix: `RecursiveSNARK::new` should set r_*_primary to default values
mpenciak Feb 28, 2024
2aebeb3
u <-> U in folding data Alloc
mpenciak Mar 1, 2024
bccabb6
fix: add trivialization for cyclefold checks in base case
mpenciak Mar 1, 2024
8cdfea3
make prove_verify test more fun
mpenciak Mar 1, 2024
a2d1ed8
fix: fix hashing order
mpenciak Mar 2, 2024
7445a59
fix: r_bools was always None
mpenciak Mar 3, 2024
4fab7cb
make prove_verify test longer
mpenciak Mar 3, 2024
051bab8
clippy
mpenciak Mar 3, 2024
b4dc789
test_augmented_circuit_size should check synthesis works
mpenciak Mar 3, 2024
40abbec
chore: fix rebase
mpenciak Mar 3, 2024
07d92c9
chore: bump msrv
mpenciak Mar 3, 2024
90cc205
chore: cleanup, documentation, and split cyclefold test
mpenciak Mar 6, 2024
13d146f
fix: Fix CycleFold circuit IO to only have arity 4
mpenciak Mar 7, 2024
59577f6
chore: update cyclefold_circuit_size expecttest
mpenciak Mar 7, 2024
e735e9e
fix: fix RO absorb counts and logic
mpenciak Mar 7, 2024
6381ccf
chore: update cyclefold primary circuit size expecttest
mpenciak Mar 7, 2024
0fafbeb
chore: cleanup and docs
mpenciak Mar 7, 2024
f912350
fix: fix rebase
mpenciak Mar 7, 2024
0232b8d
chore: fix clippy lints
mpenciak Mar 7, 2024
a123ba3
fix: constrain `AllocatedEmulPoint::default`
mpenciak Mar 8, 2024
8f0f425
tidy: use `AllocatedNum::add`
mpenciak Mar 8, 2024
67f9a92
chore: fix rebase errors in `src/gadgets`
mpenciak Mar 8, 2024
5d48fc6
fix: fix import
mpenciak Mar 8, 2024
b83d57c
chore: update expecttests
mpenciak Mar 8, 2024
938877b
tidy: add new constant
mpenciak Mar 22, 2024
497aef7
tidy: Cyclefold -> CycleFold
mpenciak Mar 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix import
mpenciak committed Mar 8, 2024
commit 5d48fc64dbcbcebc2f428bfa180d88945e91123a
2 changes: 1 addition & 1 deletion src/gadgets/nonnative/bignat.rs
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ use super::{
},
OptionExt,
};
use bellpepper_core::{boolean::AllocatedBit, ConstraintSystem, LinearCombination, SynthesisError};
use bellpepper_core::{ConstraintSystem, LinearCombination, SynthesisError};
use ff::PrimeField;
use itertools::Itertools as _;
use num_bigint::BigInt;