Skip to content

Commit

Permalink
ci: Fix errors (#264)
Browse files Browse the repository at this point in the history
samuelburnham authored Jan 16, 2024
1 parent 8295dcc commit 87327fd
Showing 2 changed files with 5 additions and 6 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/gpu-bench.yml
Original file line number Diff line number Diff line change
@@ -105,23 +105,22 @@ jobs:
else
REGRESSION_FACTOR=1.3
fi
echo "NOISE_THRESHOLD=$(echo "(REGRESSION_FACTOR-1)*100" | bc) | tee -a $GITHUB_ENV
echo "NOISE_THRESHOLD=$(echo "($REGRESSION_FACTOR-1)*100" | bc)" | tee -a $GITHUB_ENV
for r in $REGRESSIONS
do
if (( $(echo "$r >= $REGRESSION_FACTOR" | bc -l) ))
then
exit 1
echo "regression=true" | tee -a $GITHUB_OUTPUT
fi
done
continue-on-error: true
# Not possible to use ${{ github.event.number }} with the `merge_group` trigger
- name: Get PR number from merge branch
if: steps.regression-check.outputs.regression == 'true'
run: |
echo "PR_NUMBER=$(echo ${{ github.event.merge_group.head_ref }} | sed -e 's/.*pr-\(.*\)-.*/\1/')" | tee -a $GITHUB_ENV
- uses: JasonEtco/create-an-issue@v2
if: steps.regression-check.outcome == 'failure'
if: steps.regression-check.outputs.regression == 'true'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ env.PR_NUMBER }}
2 changes: 1 addition & 1 deletion benches/justfile
Original file line number Diff line number Diff line change
@@ -29,8 +29,8 @@ gpu-bench +benches:

# Run CUDA benchmarks on GPU, tuned for CI on Linux x86_64
gpu-bench-ci +benches:
printenv PATH
#!/bin/sh
printenv PATH
if [ $(uname -m) = "x86_64" ]; then
FEATURES="cuda,asm"
else

1 comment on commit 87327fd

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Table of Contents

Overview

This benchmark report shows the Arecibo GPU benchmarks.
NVIDIA L4
Intel(R) Xeon(R) CPU @ 2.20GHz
32 vCPUs
125 GB RAM
Workflow run: https://github.com/lurk-lab/arecibo/actions/runs/7546329367

Benchmark Results

RecursiveSNARKSuperNova-2circuit

ref=8295dccb0f892986c75602e0d1127c3be0bb4619
Prove-StepCircuitSize-... 53.88 ms (✅ 1.00x)
Verify-StepCircuitSize... 32.70 ms (✅ 1.00x)
Prove-StepCircuitSize-... #2 349.59 ms (✅ 1.00x)
Verify-StepCircuitSize... #2 252.53 ms (✅ 1.00x)

CompressedSNARKSuperNova-Commitments-2circuit

ref=8295dccb0f892986c75602e0d1127c3be0bb4619
Prove-Ste... 14.02 s (✅ 1.00x)
Verify-St... 78.54 ms (✅ 1.00x)
Prove-Ste... #2 113.40 s (✅ 1.00x)
Verify-St... #2 769.47 ms (✅ 1.00x)

Made with criterion-table

Please sign in to comment.