Skip to content

Commit

Permalink
chore: Upgrade rust toolchain (#272)
Browse files Browse the repository at this point in the history
- Added `#[allow(clippy::map_identity)]` clause to the `verify` function in `src/provider/non_hiding_kzg.rs` to avoid Clippy's interference
- Upgraded the Rust toolchain to version `1.75` in `rust-toolchain.toml`.
- Closes #266
huitseeker authored Jan 19, 2024
1 parent 61905bd commit 2858db1
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[toolchain]
# The default profile includes rustc, rust-std, cargo, rust-docs, rustfmt and clippy.
profile = "default"
channel = "1.73"
channel = "1.75"
targets = [ "wasm32-unknown-unknown" ]

1 change: 1 addition & 0 deletions src/provider/non_hiding_kzg.rs
Original file line number Diff line number Diff line change
@@ -327,6 +327,7 @@ where
),
(proof.proof, verifier_param.beta_h.into()),
];
#[allow(clippy::map_identity)] // this does by_ref() on a tuple
let pairing_input_refs = pairing_inputs
.iter()
.map(|(a, b)| (a, b))

1 comment on commit 2858db1

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Table of Contents

Overview

This benchmark report shows the Arecibo GPU benchmarks.
NVIDIA L4
Intel(R) Xeon(R) CPU @ 2.20GHz
32 vCPUs
125 GB RAM
Workflow run: https://github.com/lurk-lab/arecibo/actions/runs/7579515530

Benchmark Results

RecursiveSNARK-NIVC-2

ref=61905bd ref=2858db1
Prove-NumCons-6540 53.95 ms (✅ 1.00x) 53.55 ms (✅ 1.01x faster)
Verify-NumCons-6540 32.71 ms (✅ 1.00x) 32.79 ms (✅ 1.00x slower)
Prove-NumCons-1028888 349.22 ms (✅ 1.00x) 344.49 ms (✅ 1.01x faster)
Verify-NumCons-1028888 258.63 ms (✅ 1.00x) 252.53 ms (✅ 1.02x faster)

CompressedSNARK-NIVC-Commitments-2

ref=61905bd ref=2858db1
Prove-NumCons-6540 14.07 s (✅ 1.00x) 14.17 s (✅ 1.01x slower)
Verify-NumCons-6540 78.27 ms (✅ 1.00x) 78.91 ms (✅ 1.01x slower)
Prove-NumCons-1028888 113.15 s (✅ 1.00x) 113.20 s (✅ 1.00x slower)
Verify-NumCons-1028888 767.42 ms (✅ 1.00x) 769.70 ms (✅ 1.00x slower)

Made with criterion-table

Please sign in to comment.