Removing hardcoded JSONs (grumpkin) #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ark and vk from commit-hash gor Grumpkin.
|
!test |
|
!test |
storojs72
changed the title
|
End-to-end https://github.com/lurk-lab/solidity-verifier/actions/runs/8175660599 |
|
!test |
|
End-to-end https://github.com/lurk-lab/solidity-verifier/actions/runs/8175762513 |
|
!test |
|
End-to-end https://github.com/lurk-lab/solidity-verifier/actions/runs/8175860539 |
|
!test |
|
End-to-end https://github.com/lurk-lab/solidity-verifier/actions/runs/8176026495 |
storojs72
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Well, this is not the best practice to commit directly to a PR from another author, but grumpkin branch required a lot of rather complicated adaptations in order to finally work with dynamic JSONs generating:
- fixing the CI (unit tests);
- adapting Python script to work with CI from
mainbranch (integration tests) - changing the names of JSONs in Nova reference (lurk-lang/Nova@6ced77c)
- fixing Deployer script in Solidity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #53 and contributes to fixing #24