refactor: Improve memory efficiency in Nova's PP abomonation #1064
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
chasing_clones
branch
from
f2cfe39 to
fa4b752
Compare
- Removed the `Clone` trait from `PublicParams` struct in `nova. - Enhanced doc for memory safety in `PublicParamMemCache` in `mem_cache.rs` - Replaced cloning commands with `Arc::from_raw` function, resulting in improved memory utilization.
huitseeker
force-pushed
the
chasing_clones
branch
2 times, most recently
from
26d186c to
0d82735
Compare
huitseeker
force-pushed
the
chasing_clones
branch
from
0d82735 to
254ee22
Compare
huitseeker
changed the title
|
Shelving until I get time to come back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clonetrait fromPublicParamsstruct in `nova.PublicParamMemCacheinmem_cache.rsBlocks lurk-lang/arecibo#268