Use correct base price in PricingResponse

[se09deluca]

Base price shouldn't be customerGroup scoped, so use $basePrice where customer_group_id is false.

The basePrice is initially retrieved correctly:

lunar/packages/core/src/Managers/PricingManager.php

Line 198 in 467b497

$basePrice = $prices->first(fn ($price) => $price->tier == 1 && ! $price->customer_group_id);

then is not used in PricingResponse, instead is newly retrieved loosing the condition that customer_group_id must be false.

lunar/packages/core/src/Managers/PricingManager.php

Line 220 in 467b497

base: $prices->first(fn ($price) => $price->tier == 1),

That makes potentially get the wrong price as basePrice

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lunar-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 23, 2025 10:10pm

[se09deluca]

I think the issue is present even in the newest 1.x branch. If you'll accept this PR, i'll create a new on based on that branch.

[alecritson]

@se09deluca Thanks for the fix, so is this PR valid or do you need to resubmit?

[se09deluca]

@se09deluca Thanks for the fix, so is this PR valid or do you need to resubmit?

@alecritson
Yes, from my point of view this PR is valid for the 0.8x branch. I experienced a bug in an ecommerce based on that version of lunar, so this would fix it in 0.8x branch. Later, if this PR will be accepted, i will create a new similar PR for 1.x branch.

It's ok ?