Addition of getCartQuantity method on the CartSessionManager #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrispage1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two updates to the
CartSessionManagerclassAbstraction of cart ID retrieval so anyone can get the current cart ID
Addition of a
getCartQuantitymethod which will allow fetching the current quantity of all line items with minimal queries.Addition of
onlyVisibleto the customerGroups scope to be able to limit products down based on visibilityThe reason for this addition is that to load the basket quantity at the top of the page uses lots more queries than is necessary, if I am indeed simply fetching the basket quantity.
I have also added a test for this.
Thanks!