Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to support Lua 5.4 #109

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Conversation

mpeterv
Copy link
Contributor

@mpeterv mpeterv commented Mar 16, 2018

lfs is already almost compatible with Lua 5.4, just need to fix an overly strict version check. With this patch lfs compiles and passes tests under Lua 5.4 work1, with and without -DNILINTABLE.

@coveralls
Copy link
Collaborator

coveralls commented Mar 16, 2018

Coverage Status

Coverage remained the same at 80.144% when pulling 66482b9 on mpeterv:lua54-support into 1dfb8c4 on keplerproject:master.

@leokaplan
Copy link

Some libraries depend on lfs (in special busted). This would greatly ease the development in Lua 5.4

@hishamhm hishamhm merged commit 04ba8d6 into lunarmodules:master Apr 20, 2020
@hishamhm
Copy link
Member

@leokaplan Thanks for the ping (and hi there, long time no see!) — it feels so bittersweet to merge a PR from @mpeterv. I will push a patch release containing this.

@hishamhm
Copy link
Member

@leokaplan btw, have you tested that this is sufficient for supporting the latest rc of Lua 5.4?

@hishamhm hishamhm mentioned this pull request Apr 21, 2020
@leokaplan
Copy link

leokaplan commented Apr 21, 2020

I've compiled it with the latest release of 5.4 and ran with LUA_CPATH=./src/?.so lua5.4 tests/test.lua
then i've got:

LuaFileSystem 1.7.0
.............Ok!

So I think that everything is ok.
Also checked on the REPL, require'd it and played a little...

@leokaplan
Copy link

leokaplan commented Apr 21, 2020

Being merged will it automatically change in luarocks?

@hishamhm
Copy link
Member

No, I need to tag a new version number and push a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants