Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(depencies): update storybook, babel and caniuse-lite #1033

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

gcornut
Copy link
Member

@gcornut gcornut commented Dec 7, 2023

General summary

Updating the storybook, babel and caniuse-lite dependencies (all are dev dependencies)

Tests:

  • Test local dev
    • yarn start ✔️
    • yarn storybook ✔️
    • yarn build ✔️
  • Test CI ✔️
  • Test chromatic deploy ✔️
  • Test alpha release (build & publish process) ✔️
  • Test the alpha version has no regression 🚧

StoryBook: https://c7ccfb83--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build) ⚠️ Outdated commit

@gcornut gcornut force-pushed the chore/update-storybook branch from 13f8178 to 24fd906 Compare December 15, 2023 15:51
@gcornut gcornut force-pushed the chore/update-storybook branch from 24fd906 to c7ccfb8 Compare December 15, 2023 15:59
@gcornut gcornut changed the title chore(storybook): update dependencies chore(depencies): update storybook, babel and caniuse-lite Dec 15, 2023
@gcornut gcornut marked this pull request as ready for review December 15, 2023 16:01
@gcornut gcornut requested review from lumautomation, matmkian and a team as code owners December 15, 2023 16:01
@gcornut
Copy link
Member Author

gcornut commented Dec 15, 2023

Testing:

@gcornut gcornut force-pushed the chore/update-storybook branch from c7ccfb8 to 8abb154 Compare December 19, 2023 12:42
@gcornut gcornut changed the base branch from master to chore/ci-code-type-check December 19, 2023 13:55
@gcornut gcornut force-pushed the chore/update-storybook branch from 8abb154 to c34d3f1 Compare December 19, 2023 13:57
Base automatically changed from chore/ci-code-type-check to master January 4, 2024 09:09
@gcornut gcornut force-pushed the chore/update-storybook branch from c34d3f1 to ed488a6 Compare January 4, 2024 16:14
@gcornut gcornut force-pushed the chore/update-storybook branch from ed488a6 to 36799bf Compare January 5, 2024 10:41
@gcornut
Copy link
Member Author

gcornut commented Jan 5, 2024

Testing a new alpha version (after #1063 is merge) https://github.com/lumapps/design-system/actions/runs/7420877101

@gcornut
Copy link
Member Author

gcornut commented Jan 5, 2024

Test OK, no apparent regression on all devtools or on release (tested with all lumapps automated tests)

@gcornut gcornut merged commit 3b09dd7 into master Jan 5, 2024
9 checks passed
@gcornut gcornut deleted the chore/update-storybook branch January 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants