Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix package-lock and remove @erc725 in LSP7/8 package as already obtained from LSP4 package #990

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Jan 13, 2025

What does this PR introduce?

📦 Build

  • Fix package-lock.json corrupted (after removing the version field from the root package.json) by re-generating it.
  • Remove dependencies on @erc725/smart-contracts in LSP7 and LSP8 package to avoid confusion (ERC725 package is not used directly in LSP7/8 packages, but rather inherited as @erc725/smart-contracts-v8 from the LSP4 dependency).

PR Checklist

  • Wrote Tests
  • Wrote & Generated Documentation (readme/natspec/dodoc)
  • Ran npm run lint && npm run lint:solidity (solhint)
  • Ran npm run format (prettier)
  • Ran npm run build
  • Ran npm run test

@CJ42 CJ42 merged commit 925b89e into main Jan 13, 2025
2 checks passed
@CJ42 CJ42 deleted the build/fix-package-lock branch January 13, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants