Continue Node4 (LTS) Support #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could always use buble and have a prepublish script to convert the files to node v4 compatible and then when v4 is officially dropped, stop using the prepublish script. Unlike babel, buble will probably provide 99% of what you want with 0 configuration. |
|
Probably, yes, but I'm basically okay with this. 4 support ends when @lukeed ? |
|
Yes, but would have to be careful to leave the external dependencies as external dependencies, otherwise we package code that will be downloaded and linked elsewhere, without sharing. LTS ends April, so I don't mind this for a little while. No substantial changes. I also want to avoid a compile step, if possible, and really would want more reason to need a compile besides an ES5 transformation. |
pine
referenced
this pull request
in taskrjs/fly-mocha
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped
4.xsupport a bit too early. It turns out that many developers & OSS projects still actively support & use v4, so we should too in order to be approachable. This was my only hesitation before switching.Nothing changes in terms of performance or features. One
spreadand onerestoperator were changed within Fly's actual codebase. Every other change is a destructured assignment thrurequire().Opens #242 once again. Will revisit in April.