Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurse on directories specified on the command line #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ichernev
Copy link

I noticed that -R only recurses on the current directory. Sometimes its desirable to recurse on a sub-directory.

So in this patch I try to recurse on all given directories.

I'm not sure how to run the tests / install the env so you have to check if that still works :) (or let me know how to set it up).

@lukaszkorecki
Copy link
Owner

@ichernev Hi! Thanks for the pull request!

To set yourself up you will need:

  • a ruby installation
  • bundler gem (install with (sudo) gem install bundler
  • all dependencies - install them with bundle install --path=vendor

to run tests simply execute: bundle exec rspec in project's root directory.

I will update the readme to explain how to set the project up. So far I can see your PR didn't break anything thanks to Travis CI testing all branches :-)

@mtscout6
Copy link
Collaborator

While it appears that no tests were broken, I would like to see new tests showing that it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants