Dump departmental data as CSV files

[tomx4096]

Status

Ready for review / in progress

Description of Changes

Fixes #489

Changes proposed in this pull request:

• Download a department's officer data as CSV
• Download a department's incident data (if available) as CSV
• Unit tests

Notes for Deployment

The final presentation and formatting of data in the CSVs is undecided and open to feedback. Better str methods in some of the model objects would improve presentation

Screenshots (if appropriate)

Tests and linting

• I have rebased my changes on current develop

• pytests pass in the development environment on my local machine

• flake8 checks pass

[redshiftzero]

very cool feature! a couple comments inline

[redshiftzero]

Let's remove the notes from the CSV, the reason being is that the notes are actually for admins/area coordinators to add private notes to a profile, so we don't want to expose them to regular users

[redshiftzero]

Let's add a string representation for Location so the output here is nice, i.e.:

diff --git a/OpenOversight/app/models.py b/OpenOversight/app/models.py
index c4b944b..9e87a13 100644
--- a/OpenOversight/app/models.py
+++ b/OpenOversight/app/models.py
@@ -222,6 +222,20 @@ class Location(db.Model):
     def validate_state(self, key, state):
         return state_validator(state)
 
+    def __repr__(self):
+        if self.street_name and self.cross_street2:
+            return 'Intersection of {} and {}, {} {}'.format(
+                self.street_name, self.cross_street2, self.city, self.state)
+        elif self.street_name and self.cross_street1:
+            return 'Intersection of {} and {}, {} {}'.format(
+                self.street_name, self.cross_street1, self.city, self.state)
+        elif self.street_name and self.cross_street1 and self.cross_street2:
+            return 'Intersection of {} between {} and {}, {} {}'.format(
+                self.street_name, self.cross_street1, self.cross_street2,
+                self.city, self.state)
+        else:
+            return '{} {}'.format(self.city, self.state)
+

[redshiftzero]

Not necessary for merge on this PR, but just a thought: we should have the officers and incidents links be primary, and the raw data downloads be somewhere less central. One good place on the site might be a link on the footer to a new route that has the CSV download links for each department:

If you feel like implementing this (or if you have another better idea!) feel free, else we can defer to a followup.

[tomx4096]

Thanks for the review @redshiftzero . I removed the notes from the CSV, added your Location representation, and changed the location of the download links to the footer:

[redshiftzero]

excellent! thanks @tomx4096 for the contribution and @r4v5 for resolving the merge conflicts