Remove Flask-Sitemap package
#1139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
commented
Dec 18, 2024
| @@ -44,7 +41,6 @@ | |||
| ENCODING_UTF_8 = "utf-8" | |||
| FILE_TYPE_HTML = "html" | |||
| FILE_TYPE_PLAIN = "plain" | |||
| SAVED_UMASK = os.umask(0o077) # Ensure the file is read/write by the creator only | |||
There was a problem hiding this comment.
This constant is unused.
michplunkett
commented
Dec 18, 2024
| @@ -124,23 +123,6 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| # Ensure the file is read/write by the creator only | |||
| SAVED_UMASK = os.umask(0o077) | |||
There was a problem hiding this comment.
This constant is unused.
michplunkett
changed the title
Flask-Sitemap package
michplunkett
requested review from
b-meson,
AetherUnbound,
abandoned-prototype and
sea-kelp
|
Sitemap is failing due to the large amount of data we have. It's good to keep it, but we may need to adjust how it's used to actually make it work. Thanks for the extra info, @sea-kelp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
AFAIK, we do not seem to be using Sitemap within the application to any meaningful extent. There is no mention of it in the documentation, and it seems to only be loosely used throughout the application. If we are looking to flesh out the API further, I think it's worth removing it and potentially adding it back in a more explicit manner so that it doesn't seem like it's just legacy code.
Documentation: link.
Screenshots (if appropriate)
Tests and Linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.