Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.12.1: Removed unused components, corrected version #257

Conversation

andrewjswan
Copy link

No description provided.

@andrewjswan
Copy link
Author

@lubeda Do you have any comments?

@lubeda
Copy link
Owner

lubeda commented Dec 7, 2024

Why did you comment all "EHMTXv2_MULTICOLOR_TEXT" out instead of deleting them?

@andrewjswan
Copy link
Author

Why did you comment all "EHMTXv2_MULTICOLOR_TEXT" out instead of deleting them?

As far as I remember, it was an attempt to remake the current version. I decided to leave it, but make it so that it does not get into the firmware. Well, so as not to do it again in the future. If you do not need it, you can delete it, or let me know, I will delete it.

@andrewjswan
Copy link
Author

I cleanup code...

@lubeda lubeda merged commit e11dd39 into lubeda:2024.12.0 Dec 11, 2024
1 check passed
@andrewjswan andrewjswan deleted the 2024.12.1-Removed_unused_components_corrected_version branch December 11, 2024 15:05
@andrewjswan
Copy link
Author

@lubeda Hi!
I didn't delete multicolor_text , I left it and it should work, I only deleted unused procedures (which I didn't add and they weren't used in the code).
But in 2024.12.0 multicolor_text is there, and in 2024.12.1 it's gone... How to get it back?

@andrewjswan
Copy link
Author

2024.12.0...2024.12.1

@andrewjswan
Copy link
Author

I make new PR
#264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants