Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.9.1: Add text progress screen #144

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

andrewjswan
Copy link

@chertvl
Copy link

chertvl commented Nov 11, 2023

it seems very accurate
useful for me, thank you!

@lubeda lubeda merged commit 2339525 into lubeda:2023.9.1 Nov 13, 2023
5 checks passed
@lubeda
Copy link
Owner

lubeda commented Nov 13, 2023

Why text and value? if text and value are long the overwrite each other? I think value is enough or text should scroll.

@andrewjswan
Copy link
Author

Why text and value?

Text on left, value on right ...

if text and value are long the overwrite each other?

Yes

I think value is enough or text should scroll.

Well, I did not want to make the text scrolling, but it is generally not difficult, but you need to write a calculator to understand the width of the value, and what if the width of the value will be 30 characters?
And so let the user decide for himself how it is more convenient for him.

@lubeda
Copy link
Owner

lubeda commented Nov 14, 2023

HI, I'm not sure what's the best way. Due to the limited screen space there are always some draw backs. Without scrolling I think the best way is to check the pixels for value and text if the fin in 32 pixel display both, if don't display only the text because the value is indicated somehow with the bar.

A limitation based on character count is quite random.

What do you think?

@andrewjswan
Copy link
Author

I don't mind, but it seems to me that this is such a specific screen that those who will use it will be able to define and shorten the text and value so that everything is on the screen. But I like your idea, it won't be a mess, just text.

@andrewjswan andrewjswan deleted the 2023.9.1-Add_text_progress_screen branch November 14, 2023 18:44
@chertvl
Copy link

chertvl commented Nov 14, 2023

But I like your idea, it won't be a mess, just text.

I agree.
For my tasks (4symb text) + (3symb value + '%') is enogh, as I asked in issue.
Any improvements I support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants