Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2023.9.1: Add Bitmap Stack screen #140

Merged
merged 31 commits into from
Nov 10, 2023
Merged

2023.9.1: Add Bitmap Stack screen #140

merged 31 commits into from
Nov 10, 2023

Conversation

andrewjswan
Copy link

@andrewjswan
2023.9.1: Add Bitmap stack screen
85630f9
@andrewjswan
2023.9.1: Add Bitmap stack screen
33ff497
@andrewjswan
2023.9.1: Add calc_scroll_time for Bitmap stack
aa7a727
@andrewjswan
2023.9.1: Add Bitmap stack screen
3d58e6d
@andrewjswan
2023.9.1: Add Bitmap stack screen
e1c6113
@andrewjswan
2023.9.1: Add calc_scroll_time declaration
f0492e8
@andrewjswan
2023.9.1: Fix typo
f2dfaec
@andrewjswan
2023.9.1: bitmap_stack rework
8b71f57
@andrewjswan
2023.9.1: Rework bitmap_stack screen
25ff4ee
@andrewjswan
2023.9.1: Add bitmap_stack to queue status
bb281b1
@andrewjswan
2023.9.1: Add average_frame_duration to update
18d0d9a
@andrewjswan
2023.9.1: Reset frame in bitmap stack icons
03aa9f3
@andrewjswan
2023.9.1: Reset frame in bitmap stack icons
121b25a
@andrewjswan
2023.9.1: Reset frame in bitmap stack icons
d7b5a6a
@andrewjswan
2023.9.1: Add reverse steps for bitmap stack
6efa1ef
@andrewjswan
2023.9.1: Prepare for different side scroll in bitmap stack
41f9acf
@andrewjswan
2023.9.1: Add two side scroll to bitmap stack
2ac6f91
@andrewjswan
2023.9.1: Add mode switch for scroll method
af9bf73
@andrewjswan
2023.9.1: Preparing for a negative icon position in the stack
e1ceeb8
@andrewjswan
2023.9.1: Preparing for a negative icon position in the stack
a5e6bd6
@andrewjswan
2023.9.1: Add ypos
e74872e
@andrewjswan
2023.9.1: Fix scroll mode
4ada38f
@andrewjswan
2023.9.1: Bitmap stack beta version
1262da9
@andrewjswan
2023.9.1: Rework bitmap stack metrics
a6136e2
@andrewjswan
2023.9.1: Fix rollback tick step
8073076
@andrewjswan
2023.9.1: Safe and Cosmetic
1de538f
@andrewjswan
2023.9.1: Safe and Cosmetic
d509026
@andrewjswan
2023.9.1: Cosmetic
e58a107
@lubeda
Copy link
Owner

lubeda commented Nov 9, 2023

What about the readme? Why did you change calc scroll time?

@andrewjswan
Copy link
Author

I dont change, only add new for icons

    void calc_scroll_time(std::string text, uint16_t screen_time);
    void calc_scroll_time(uint8_t icon_count, uint16_t screen_time);

Readme updated ...

@lubeda lubeda merged commit c3350db into lubeda:2023.9.1 Nov 10, 2023
5 checks passed
@andrewjswan andrewjswan deleted the 2023.9.1-Add_Bitmap_stack_screen branch November 10, 2023 16:00
@lubeda
Copy link
Owner

lubeda commented Nov 10, 2023

Hi, its a nice effect but the |two "parameter" isn't a clean way to pass parameters and the functionality isn't described in the readme.

@andrewjswan
Copy link
Author

I added 2 examples at the bottom of the Readme, I just don't quite understand how to describe it clearly, should see the effect working on the 1,2,3 icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewjswan @lubeda