Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-48290: Add hpp files to python sdist #80

Merged
merged 1 commit into from
Jan 4, 2025
Merged

DM-48290: Add hpp files to python sdist #80

merged 1 commit into from
Jan 4, 2025

Conversation

mwittgen
Copy link
Contributor

@mwittgen mwittgen commented Jan 4, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@mwittgen mwittgen requested a review from timj January 4, 2025 18:53
@mwittgen mwittgen mentioned this pull request Jan 4, 2025
Closed
3 tasks
@timj
Copy link
Member

timj commented Jan 4, 2025

Makes me think that we should be checking that the sdist actually builds before we do the upload.

@mwittgen mwittgen merged commit 8365541 into main Jan 4, 2025
17 checks passed
@mwittgen mwittgen deleted the tickets/DM-48290 branch January 4, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roceb roceb roceb approved these changes

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwittgen @timj @roceb