Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-30682: Rename "flags_negative" to "is_negative" #293

Closed
wants to merge 2 commits into from

Conversation

abudlong
Copy link
Contributor

No description provided.

@JeremyMcCormick
Copy link
Collaborator

JeremyMcCormick commented Dec 13, 2024

I would recommend that these validation errors be fixed if this schema is actually in use:

INFO:felis:Validating ./yml/archive/sdss_stripe82_01.yml
ERROR:felis:3 validation errors for Schema
tables.1.columns.8.ivoa:ucd
  Value error, Invalid IVOA UCD: Unknown word 'pos.equinox' [type=value_error, input_value='pos.equinox', input_type=str]
    For further information visit https://errors.pydantic.dev/2.10/v/value_error
tables.7.columns.9.ivoa:ucd
  Value error, Invalid IVOA UCD: Unknown word 'pos.equinox' [type=value_error, input_value='pos.equinox', input_type=str]
    For further information visit https://errors.pydantic.dev/2.10/v/value_error
tables.7.columns.31.defaultValue
  Extra inputs are not permitted [type=extra_forbidden, input_value='CURRENT_TIMESTAMP', input_type=str]
    For further information visit https://errors.pydantic.dev/2.10/v/extra_forbidden

Because the YAML file is in the archive directory, it will not be validated automatically in CI.

@JeremyMcCormick JeremyMcCormick added the schema Update a schema or add a new one label Dec 16, 2024
@JeremyMcCormick
Copy link
Collaborator

JeremyMcCormick commented Dec 19, 2024

@abudlong

See my comment on DM-30682

You should drop both these commits and start over, as it seems there is confusion about what this ticket is actually supposed to accomplish. The archived schema should not be modified, and apdb.yaml versions are incremented only when there are other changes to that file like adding/deleting columns, etc.

Please discuss in the ticket comments on Jira if you have questions or need clarification on this work.

@abudlong abudlong closed this Dec 22, 2024
@abudlong abudlong deleted the tickets/DM-30682 branch December 22, 2024 17:51
@abudlong abudlong restored the tickets/DM-30682 branch December 22, 2024 17:55
@abudlong abudlong deleted the tickets/DM-30682 branch December 22, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Update a schema or add a new one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants