DM-48013: Add contribution guide and pull request template #290
Conversation
.github/pull_request_template.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| ## Checklist | |||
|
|
|||
| - [ ] If changing `apdb.yaml`, it usually requires version number increment, check [schema versioning page](https://rubinobs.atlassian.net/wiki/external/OGUyOGM1OTY0MTRkNGFmNThkNWM4N2U1NGFmODJkNWY) for details. | |||
There was a problem hiding this comment.
I think @ebellm said that changes to apdb.yaml also need to be synchronized with https://github.com/lsst/alert_packet?
There was a problem hiding this comment.
We can certainly mention that too, please suggest wording for it.
There was a problem hiding this comment.
I think @ebellm said that changes to
apdb.yamlalso need to be synchronized with https://github.com/lsst/alert_packet?
I see that there are detailed instructions on synchronizing alert_packet with sdm_schemas under Adding a New Schema.
We can provide a direct link to this section in the sdm_schemas docs which cover the APDB.
There was a problem hiding this comment.
I'm going to put a review hold on this for the time being so it doesn't get inadvertently merged. I discussed with Andy today about making a more generic checklist and contribution guide and will take over development on this branch.
I have no problem if we eventually create a dedicated page for APDB considerations within sdm_schemas itself, too, e.g., incorporating information like that mentioned in #290 (comment). That could be on a separate branch/ticket from the more generic contribution guide and checklist.
I don't think we should link to Confluence pages. I would prefer if it was self-contained and the checklist pointed to pages within the sdm_schemas repository, only.
JeremyMcCormick
force-pushed
the
tickets/DM-48013
branch
from
06619c8 to
5732735
Compare
|
I'm going to re-open a new PR so Andy can be a reviewer. |
JeremyMcCormick
changed the title
No description provided.