Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47844: Add workflow that runs extra validation checks #287

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Nov 28, 2024

  • Addded a workflow that runs all extra validation checks
    • This does not run automatically. It needs to be triggered with workflow dispatch.
  • Removed the old validator workflow and script
  • Updated the existing validation workflow to use the test setup action
  • Simplified the name of the main validation workflow to "Validate Schemas"

@JeremyMcCormick JeremyMcCormick requested a review from gpdf November 28, 2024 16:16
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-47844 branch 3 times, most recently from d02aabc to 9eecc38 Compare November 28, 2024 17:11
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-47844 branch 4 times, most recently from 8e5dd52 to 4ee7481 Compare December 6, 2024 20:41
Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but since apparently there's no way to actually execute it before it's merged, please merge this only when you feel you have time to do a followup if it doesn't work.

@JeremyMcCormick JeremyMcCormick merged commit 43bd5d1 into main Dec 10, 2024
10 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-47844 branch December 10, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants