-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-41867: Add improvements to schema browser #256
Conversation
24ccd7b
to
6dcb7b7
Compare
bb81c85
to
5d20b0b
Compare
04ec583
to
d5774d7
Compare
d5774d7
to
15ecd2d
Compare
e4c2e0c
to
3e91a72
Compare
71d0373
to
a376c61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed as-deployed on a branch on this doc site, on 2024-10-16 and -18.
Last request: restore the ordering of tables from the existing schema browser.
Add DataTables support which provides pagination, sorting by column, and textual search capability. Also add additional columns to the schema browser: UCD, Index and Principal. Initially sort the table first by Index and then Column Name.
This is not needed any longer with the DataTables sorting.
This no longer needed, because the pages have been changed to use the site upload date, instead.
a376c61
to
e6f0cd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now. Deploy!
Adds the following improvements and features to the schema browser:
Advanced table features were enabled by the well-known DataTables Javascript library and its script dependencies.
Also included several miscellaneous fixes:
last_modified
(Otherwise, this only updates when the HTML pages themselves are changed, which does not work for our purposes.)last_modified
plugin config, as it is no longer required(Many of these features and fixes are outside the scope of the original ticket, but they were fairly minimal in terms of updating the HTML files. So I decided to bundle them together in one update.)