DM-43115: Add missing primary keys to DP0.2 schema #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyMcCormick
force-pushed
the
tickets/DM-43115
branch
4 times, most recently
from
8767d21 to
ac72dc9
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-43115
branch
from
ac72dc9 to
9227584
Compare
gpdf
approved these changes
Sep 27, 2024
| @@ -7872,6 +7880,7 @@ tables: | |||
| - name: TruthSummary | |||
| '@id': '#TruthSummary' | |||
| description: Summary properties of objects from the DESC DC2 truth catalog, as described in arXiv:2101.04855. Includes the noiseless astrometric and photometric parameters. | |||
| primaryKey: "#TruthSummary.id_truth_type" | |||
There was a problem hiding this comment.
It's OK to do this now, as in practice this attribute seems to be the one used for JOINs and functions "as if" it were the primary unique key, but...
It's not clear why id is not the primary key. The description says it's unique, but in the MatchesTruth table there's a hint that it might not be unique (and so that the truth_type has to be included to achieve uniqueness).
Please add a comment to the YAML to note that anyone re-using this table's schema should think again about whether this is the right choice.
Some foreign key constraints were missing primary key designations on the target column, causing errors during database instantiation.
This should work for all databases now.
JeremyMcCormick
force-pushed
the
tickets/DM-43115
branch
from
9227584 to
e0e6684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes errors with foreign key constraints when creating the database for the DP0.2 schema.
The
--ignore-constraintsflag was removed from the database creation script used in the Github workflows.