DM-44158: Add database tests #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyMcCormick
force-pushed
the
tickets/DM-44158
branch
29 times, most recently
from
0e62f1b to
dc355de
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-44158
branch
8 times, most recently
from
73e44fa to
d8c2682
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-44158
branch
2 times, most recently
from
68fb6f0 to
0cd2791
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-44158
branch
from
0cd2791 to
fddfdd1
Compare
Insert a dummy mysql:datatype so that the schema can be instantiated into MySQL during CI.
The maximum length of a char column in MySQL is 255, so the string type needs to be used here instead.
JeremyMcCormick
force-pushed
the
tickets/DM-44158
branch
from
fddfdd1 to
826f2e0
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-44158
branch
from
826f2e0 to
0c9d5b3
Compare
gpdf
approved these changes
Aug 16, 2024
| @@ -7749,7 +7749,7 @@ tables: | |||
| tap:std: 1 | |||
| tap:principal: 1 | |||
| ivoa:unit: | |||
| datatype: char | |||
| datatype: string | |||
There was a problem hiding this comment.
Confirmed with @iagaponenko that this is the right type, matching what's actually deployed in Qserv, VARCHAR(512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds GitHub workflows and actions for testing whether database functionality works correctly for each schema file in the
ymldirectory. There are three separate workflows for tests using MySQL, PostgreSQL, and SQLite. These are all called viaworkflow_dispatchby thetest.yamlworkflow.Tested functionality on each schema includes:
felis createcommandfelis createcommand with--output-fileThe checks do not all pass now, because there are errors in some of these steps, mainly for MySQL.Also, TAP_SCHEMA loading does not work for any of the database types, because there are currently duplicate FK constraint names in the ConsDB schemas. (This is a known issue and will be fixed soon.)