-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-41310: Update the schema browser to use LTD #242
Conversation
9f24bb5
to
d250ba0
Compare
705c8e6
to
949d0d5
Compare
5eee186
to
dd89b52
Compare
ce88806
to
a4b6b43
Compare
Add a partial that will include a bulleted list of schemas with their names and (optionally) descriptions. The include_description parameter can be set to true if the schema's description field from the YAML file should be included; set this to false to include only the schema title.
The main SCSS file needs to be compiled to CSS. This uses the default Jekyll layout for its location, moving it from assets into _scss in the root directory of the site.
a4b6b43
to
2831577
Compare
A couple of initial comments: it would be good to have a "change version" link in the left sidebar, or people will never discover this new functionality, and it should be in every instance of the sidebar, i.e., whether you're on the top page or inside a specific schema. |
As discussed in our meeting: please also restore the ability to choose the presentation order of the schemas in the browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, thank you!
Future work: add information about string lengths
No description provided.