Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41310: Update the schema browser to use LTD #242

Merged
merged 23 commits into from
Aug 2, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

No description provided.

@JeremyMcCormick JeremyMcCormick marked this pull request as draft July 29, 2024 17:39
@JeremyMcCormick JeremyMcCormick changed the title DM-41310: Update the browser to use versioned LTD sites DM-41310: Update the browser to use LTD Jul 29, 2024
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-41310 branch 3 times, most recently from 705c8e6 to 949d0d5 Compare July 29, 2024 19:48
@JeremyMcCormick JeremyMcCormick changed the title DM-41310: Update the browser to use LTD DM-41310: Update the schema browser to use LTD Jul 29, 2024
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-41310 branch 18 times, most recently from 5eee186 to dd89b52 Compare July 30, 2024 16:32
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-41310 branch 2 times, most recently from ce88806 to a4b6b43 Compare July 30, 2024 17:05
@JeremyMcCormick JeremyMcCormick marked this pull request as ready for review July 31, 2024 03:36
@gpdf
Copy link
Collaborator

gpdf commented Jul 31, 2024

A couple of initial comments: it would be good to have a "change version" link in the left sidebar, or people will never discover this new functionality, and it should be in every instance of the sidebar, i.e., whether you're on the top page or inside a specific schema.

@gpdf
Copy link
Collaborator

gpdf commented Jul 31, 2024

As discussed in our meeting: please also restore the ability to choose the presentation order of the schemas in the browser.

Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thank you!

Future work: add information about string lengths

@JeremyMcCormick JeremyMcCormick merged commit 05a9ddc into main Aug 2, 2024
6 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-41310 branch August 2, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants