Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change mysql datatype from double to DOUBLE to fix db creation error #160

Closed
wants to merge 2 commits into from
Closed

Change mysql datatype from double to DOUBLE to fix db creation error #160

wants to merge 2 commits into from

Conversation

JeremyMcCormick
Copy link
Collaborator

This type needs to be uppercase or creating the database fails.

(I didn't create a Jira ticket for this.)

@JeremyMcCormick JeremyMcCormick requested a review from gpdf October 25, 2023 18:32
gpdf
gpdf approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Of course someday soon we're going to remove all the redundant mysql:datatype entries.

@JeremyMcCormick JeremyMcCormick force-pushed the u/jeremym/schema-hotfix1 branch from 0b2d1fb to 4ba6316 Compare October 25, 2023 21:37
@JeremyMcCormick JeremyMcCormick force-pushed the u/jeremym/schema-hotfix1 branch from 4ba6316 to f779631 Compare October 25, 2023 22:08
@JeremyMcCormick
Copy link
Collaborator Author

Moving to a ticket branch.

@JeremyMcCormick JeremyMcCormick deleted the u/jeremym/schema-hotfix1 branch May 29, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpdf gpdf gpdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyMcCormick @gpdf