Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/PREOPS-3620 #140

Merged
merged 4 commits into from
Nov 3, 2023
Merged

tickets/PREOPS-3620 #140

merged 4 commits into from
Nov 3, 2023

Conversation

MelissaGraham
Copy link
Contributor

Fix DiaObject ra, dec, radecTai descriptions.

@gpdf
Copy link
Collaborator

gpdf commented Oct 25, 2023

@MelissaGraham Could you rebase this and force-push, please? We have changed some of the CI workflows and would like to have the new CI picked up before merging this. Thanks!

@MelissaGraham
Copy link
Contributor Author

Rebased. Merge awaiting confirmation that the new definitions should be adopted. Conversation in comments of PREOPS-3620 ongoing.

Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

House style so far has been - and is elsewhere in this file - to begin the description: elements with capital letters.

@MelissaGraham
Copy link
Contributor Author

House style so far has been - and is elsewhere in this file - to begin the description: elements with capital letters.

Thank you! Updated to start with a capital letter.

Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Needs one more rebase before merging.

@MelissaGraham MelissaGraham merged commit fa7cd0d into main Nov 3, 2023
4 checks passed
@MelissaGraham MelissaGraham deleted the tickets/PREOPS-3620 branch November 3, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants