-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-29602: Release notes 22.0.x #179
base: main
Are you sure you want to change the base?
Conversation
Draft build: https://pipelines.lsst.io/v/v22_0_0_rc1/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I’ve included a few line suggestions.
The recurring issue is with links. Anything in single backticks should resolve into an API link. If it doesn’t that means there’s an issue. If I an API link can’t be made for whether (like, the docs don’t exist), then a double backtick is preferable.
conf.py
Outdated
""" | ||
|
||
# Patch EUPS and Git tag context for Jinja templating | ||
jinja_contexts = { | ||
"default": { | ||
"release_eups_tag": "v21_0_0", | ||
"release_eups_tag": "v22_0_0", | ||
"release_git_ref": "21.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t check if this is actively used, but we might want to carry the change along anyways.
releases/v22_0_0.rst
Outdated
################################### | ||
Release 22.0.0 (YYYY-MM-DD) | ||
################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
################################### | |
Release 22.0.0 (YYYY-MM-DD) | |
################################### | |
########################### | |
Release 22.0.0 (YYYY-MM-DD) | |
########################### |
Generation 2 middleware (Gen2) is no longer being developed and should not be used for new code. | ||
Gen2 infrastructure code (within e.g., :ref:`pipe_tasks <lsst.pipe.tasks>`, :ref:`pipe_base <lsst.pipe.base>`, :ref:`obs_base <lsst.obs.base>`, `daf_persistence <https://github.com:lsst/daf_persistence>`_, and obs packages) will no longer be maintained after January 1, 2022 and may be removed at any point afterwards. | ||
The CI package `ci_hsc_gen2` will continue to be run, and the tasks it checks will be maintained until we remove the Gen2 infrastructure code in 2022. | ||
Following this release, we will begin to drop gen2 pipelines from our verification packages (e.g., ap_verify), where a functional and validated gen3 pipeline exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is “Gen” capitalized at all times?
releases/v22_0_0.rst
Outdated
Removal of `afw.lsst.Filter` | ||
---------------------------- | ||
`~afw.lsst.Filter` has been replaced with :ref:`filterLabel<release-v22-0-0-filterLabel>`, marked as deprecated, and will be removed before the release of version 24.0.0. | ||
:jirab:`RFC-730` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check afw.lsst.Filter
— do you mean lsst.afw…
? Also double check the link for Filter in the rendered output. With single backticks it should either resolve into a link to should be turned into double backticks to make it an unlinked code literal.
branch is called
22.0.x
not DM-29602